Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading Flux Dev transformers from_single_file #10541

Closed
wants to merge 1 commit into from

Conversation

dxqbYD
Copy link

@dxqbYD dxqbYD commented Jan 12, 2025

Description and reproducer in:
#10540

Please check the added condition before you merge.
This code works, but I am not sure what the key in question does. It seems to be absent in transformer-only Flux.Dev files. But it could also be absent in transformer-only Flux Fill files? I don't know. In that case, a different condition to tell the two apart is needed.

Fixes #10540 (issue)

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6

since this commit huggingface@862a7d5 loading flux transformers (not: entire pipeline) from_single_file() fails
@bghira

This comment was marked as resolved.

@sayakpaul sayakpaul requested a review from DN6 January 13, 2025 13:34
@DN6
Copy link
Collaborator

DN6 commented Jan 13, 2025

@dxqbYD Flux Transformers all contain an img_in.weight key. Issue #10540 is related to the model.diffusion_model prefix that is added to Comfy checkpoints. The change here would cause issues with single file checkpoints that do not have this prefix. I've opened a fix here:
#10545

@dxqbYD
Copy link
Author

dxqbYD commented Jan 13, 2025

closing this PR in favor of #10545

@dxqbYD dxqbYD closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading Flux Dev transformers from_single_file fails since support for Flux Fill was added
3 participants