[LoRA PEFT] fix LoRA loading so that correct alphas are parsed #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
requested review from
BenjaminBossan,
pacman100,
patrickvonplaten and
younesbelkada
This was referenced Dec 19, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pacman100
reviewed
Dec 19, 2023
BenjaminBossan
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Thanks for making the adjustments!
Do we need to update the following scripts too?
examples/wuerstchen/text_to_image/train_text_to_image_lora_prior.pyexamples/research_projects/lora/train_text_to_image_lora.pyexamples/consistency_distillation/train_lcm_distill_lora_sdxl_wds.pyexamples/consistency_distillation/train_lcm_distill_lora_sd_wds.py
(possibly also with regard to init_lora_weights="gaussian")
|
checking thanks for the heads up! |
This was referenced Dec 20, 2023
younesbelkada
approved these changes
Dec 22, 2023
patrickvonplaten
approved these changes
Dec 23, 2023
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
…ngface#6225) * initialize alpha too. * add: test * remove config parsing * store rank * debug * remove faulty test
antoine-scenario
pushed a commit
to antoine-scenario/diffusers
that referenced
this pull request
Jan 2, 2024
…ngface#6225) * initialize alpha too. * add: test * remove config parsing * store rank * debug * remove faulty test
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…ngface#6225) * initialize alpha too. * add: test * remove config parsing * store rank * debug * remove faulty test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies #6135
Fixes #6087
Do go through #6135 (comment) for the full context.