Fix Prodigy optimizer in SDXL Dreambooth script #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Feel free to merge once the CI is green and sorry about the oversight on our part. |
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
* Fix ProdigyOPT in SDXL Dreambooth script * style * style
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Fix ProdigyOPT in SDXL Dreambooth script * style * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-adds the exact same Prodigy-related parameters to the SDXL Dreambooth training script that were removed in the PEFT integration commit - see here: c271731#diff-21097f487be9184775f962c08b5cd60b92a31a99da8f3e0d8caf7867f50644d9L1197-L1216
This removal at first glance doesn't seem related to PEFT, and can affect how the prodigyopt works.
Who can review?
@sayakpaul , @younesbelkada