[LoRA] make LoRAs trained with peft loadable when peft isn't installed
#6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Dec 25, 2023
@younesbelkada hence the TODO here: #6306 (comment).
Which ones? Can you pinpoint? |
Ran RUN_SLOW=1 pytest tests/lora/test_lora_layers_peft.pyWorks. |
|
@pacman100 could you also give it a look? |
|
Makes sense! As a general guideline, for now let's try to always have the exact same serialization format that we had before using PEFT in the example scritps |
patrickvonplaten
approved these changes
Dec 26, 2023
sayakpaul
added a commit
that referenced
this pull request
Dec 28, 2023
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
…alled (huggingface#6306) * spit diffusers-native format from the get go. * rejig the peft_to_diffusers mapping.
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
* add to dreambooth lora. * add: t2i lora. * add: sdxl t2i lora. * style * lcm lora sdxl. * unwrap * fix: enable_adapters().
antoine-scenario
pushed a commit
to antoine-scenario/diffusers
that referenced
this pull request
Jan 2, 2024
…alled (huggingface#6306) * spit diffusers-native format from the get go. * rejig the peft_to_diffusers mapping.
antoine-scenario
pushed a commit
to antoine-scenario/diffusers
that referenced
this pull request
Jan 2, 2024
* add to dreambooth lora. * add: t2i lora. * add: sdxl t2i lora. * style * lcm lora sdxl. * unwrap * fix: enable_adapters().
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…alled (huggingface#6306) * spit diffusers-native format from the get go. * rejig the peft_to_diffusers mapping.
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* add to dreambooth lora. * add: t2i lora. * add: sdxl t2i lora. * style * lcm lora sdxl. * unwrap * fix: enable_adapters().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reported by @apolinario. Internal thread: https://huggingface.slack.com/archives/C05GX934Z98/p1703334768186119.
Currently, our LoRA trainers use
peft. To load those LoRAs you needpeftto be installed. However, we want those LoRAs to be loadable withoutpefttoo (or so I'd think?).This PR fixes that.
peft: https://colab.research.google.com/gist/sayakpaul/cc0886ada3ecdd5c3b305cf9862d2c72/scratchpad.ipynbpeftisn't installed: https://colab.research.google.com/gist/sayakpaul/41c60a6bfb921108faf572508bc15469/scratchpad.ipynb@apolinario does this work for you?
TODO