Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Speed up example tests #6319

Merged
merged 28 commits into from
Dec 25, 2023
Merged

[Tests] Speed up example tests #6319

merged 28 commits into from
Dec 25, 2023

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Speeds up the example CPU tests by:

  • Removing validation inference from textual inversion (since we don't do that for other example tests)
  • Reduce the number of training steps whenever applicable without affecting the logical correctness

Before this PR: https://huggingface.co/datasets/sayakpaul/sample-datasets/blob/main/reports/tests_torch_example_cpu_durations.txt

After this PR: https://huggingface.co/datasets/sayakpaul/sample-datasets/blob/main/reports-speed/tests_torch_example_cpu_durations.txt

@sayakpaul
remove validation args from textual onverson tests
cba7991
@sayakpaul
reduce number of train steps in textual inversion tests
ede49cf
@sayakpaul
fix: directories.
85f3160
@sayakpaul
debig
b7dfcb9
@sayakpaul
fix: directories.
29f6ece
@sayakpaul
remove validation tests from textual onversion
ec52282
@sayakpaul
try reducing the time of test_text_to_image_checkpointing_use_ema
ff7e4ae
@sayakpaul
fix: directories
1e63a6e
@sayakpaul
speed up test_text_to_image_checkpointing
e07f9c9
@sayakpaul
speed up test_text_to_image_checkpointing_checkpoints_total_limit_rem…
bff0d05 
…oves_multiple_checkpoints
@sayakpaul
fix
b8032c7
@sayakpaul
speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit_…
e84c10a 
…removes_multiple_checkpoints
@sayakpaul
set checkpoints_total_limit to 2.
443bcd5
@sayakpaul
test_text_to_image_lora_checkpointing_checkpoints_total_limit_removes…
9d3ea31 
…_multiple_checkpoints speed up
@sayakpaul
speed up test_unconditional_checkpointing_checkpoints_total_limit_rem…
4296ce1 
…oves_multiple_checkpoints
@sayakpaul
debug
2c7e979
@sayakpaul
fix: directories.
6ec0d84
@sayakpaul
speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit
fca5113
@sayakpaul
speed up: test_controlnet_checkpointing_checkpoints_total_limit_remov…
d71605b 
…es_multiple_checkpoints
@sayakpaul
speed up test_controlnet_sdxl
e137f8a
@sayakpaul
speed up dreambooth tests
7afc283
@sayakpaul
speed up test_dreambooth_lora_checkpointing_checkpoints_total_limit_r…
4f2fcde 
…emoves_multiple_checkpoints
@sayakpaul
speed up test_custom_diffusion_checkpointing_checkpoints_total_limit_…
651cfce 
…removes_multiple_checkpoints
@sayakpaul
speed up test_text_to_image_lora_sdxl_text_encoder_checkpointing_chec…
9fa43da 
…kpoints_total_limit
@sayakpaul
speed up # checkpoint-2 should have been deleted
c1dcdc2
@sayakpaul
speed up examples/text_to_image/test_text_to_image.py::TextToImage::t…
e999faf 
…est_text_to_image_checkpointing_checkpoints_total_limit
@sayakpaul
additional speed ups
3d66d1e
@sayakpaul sayakpaul requested a review from DN6 December 25, 2023 08:35
DN6
DN6 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sayakpaul sayakpaul merged commit f4b0b26 into main Dec 25, 2023
16 checks passed
@sayakpaul sayakpaul deleted the speed-up-example-tests branch December 25, 2023 14:20
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
@sayakpaul @donhardman
[Tests] Speed up example tests (huggingface#6319)
eeb6462 
* remove validation args from textual onverson tests

* reduce number of train steps in textual inversion tests

* fix: directories.

* debig

* fix: directories.

* remove validation tests from textual onversion

* try reducing the time of test_text_to_image_checkpointing_use_ema

* fix: directories

* speed up test_text_to_image_checkpointing

* speed up test_text_to_image_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* fix

* speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* set checkpoints_total_limit to 2.

* test_text_to_image_lora_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints speed up

* speed up test_unconditional_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* debug

* fix: directories.

* speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit

* speed up: test_controlnet_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_controlnet_sdxl

* speed up dreambooth tests

* speed up test_dreambooth_lora_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_custom_diffusion_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_text_to_image_lora_sdxl_text_encoder_checkpointing_checkpoints_total_limit

* speed up # checkpoint-2 should have been deleted

* speed up examples/text_to_image/test_text_to_image.py::TextToImage::test_text_to_image_checkpointing_checkpoints_total_limit

* additional speed ups

* style
antoine-scenario pushed a commit to antoine-scenario/diffusers that referenced this pull request Jan 2, 2024
@sayakpaul @adrvs
[Tests] Speed up example tests (huggingface#6319)
7db46fa 
* remove validation args from textual onverson tests

* reduce number of train steps in textual inversion tests

* fix: directories.

* debig

* fix: directories.

* remove validation tests from textual onversion

* try reducing the time of test_text_to_image_checkpointing_use_ema

* fix: directories

* speed up test_text_to_image_checkpointing

* speed up test_text_to_image_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* fix

* speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* set checkpoints_total_limit to 2.

* test_text_to_image_lora_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints speed up

* speed up test_unconditional_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* debug

* fix: directories.

* speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit

* speed up: test_controlnet_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_controlnet_sdxl

* speed up dreambooth tests

* speed up test_dreambooth_lora_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_custom_diffusion_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_text_to_image_lora_sdxl_text_encoder_checkpointing_checkpoints_total_limit

* speed up # checkpoint-2 should have been deleted

* speed up examples/text_to_image/test_text_to_image.py::TextToImage::test_text_to_image_checkpointing_checkpoints_total_limit

* additional speed ups

* style
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@sayakpaul
[Tests] Speed up example tests (huggingface#6319)
330b67e 
* remove validation args from textual onverson tests

* reduce number of train steps in textual inversion tests

* fix: directories.

* debig

* fix: directories.

* remove validation tests from textual onversion

* try reducing the time of test_text_to_image_checkpointing_use_ema

* fix: directories

* speed up test_text_to_image_checkpointing

* speed up test_text_to_image_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* fix

* speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* set checkpoints_total_limit to 2.

* test_text_to_image_lora_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints speed up

* speed up test_unconditional_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* debug

* fix: directories.

* speed up test_instruct_pix2pix_checkpointing_checkpoints_total_limit

* speed up: test_controlnet_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_controlnet_sdxl

* speed up dreambooth tests

* speed up test_dreambooth_lora_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_custom_diffusion_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints

* speed up test_text_to_image_lora_sdxl_text_encoder_checkpointing_checkpoints_total_limit

* speed up # checkpoint-2 should have been deleted

* speed up examples/text_to_image/test_text_to_image.py::TextToImage::test_text_to_image_checkpointing_checkpoints_total_limit

* additional speed ups

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DN6 DN6 DN6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayakpaul @DN6