Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yue Model for Fal Provider #1148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Warlord-K
Copy link

No description provided.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test if possible!

@@ -28,4 +28,7 @@ export const FAL_AI_SUPPORTED_MODEL_IDS: ProviderMapping<FalAiId> = {
"THUDM/CogVideoX-5b": "fal-ai/cogvideox-5b",
"Lightricks/LTX-Video": "fal-ai/ltx-video",
},
"text-to-audio": {
Copy link
Contributor

@Wauplin Wauplin Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, the inference.js client has a text-to-speech task, not text-to-audio: https://github.com/huggingface/huggingface.js/blob/2c759b54070b0fad02220f8159eaf52bda531b0b/packages/inference/src/tasks/audio/textToSpeech.ts

(same in Python client)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true but i think the APIs are the same, so it should be quite easy to add! (single digit line of code change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants