-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cohere provider #1202
Add Cohere provider #1202
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you so much!
I took the liberty to factor some cohere-specific types into the providers/cohere
file
Test failure is unrelated to the current PR
packages/inference/test/tapes.json
Outdated
@@ -7375,6 +7375,59 @@ | |||
} | |||
} | |||
}, | |||
"772e481d98640490fca3aab8e7fed5b771ea213f2b76b2f8858ce7bc90acb16b": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: You can update the tapes file by running:
VCR_MODE=cache pnpm run test
ec5c931
to
689a061
Compare
689a061
to
e1bf67a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 🔥 Thank you for implementing an OpenAI-compatible API!
Looks good to me, let's merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner this way! Thanks for making the effort on your side 🤗
What
Adds Cohere as an inference provider.
Test Plan
Added new tests for Cohere both with and without streaming.
What Should Reviewers Focus On?
Is the implementation correct? Anything important that I missed? Also happy to get feedback on the code, I am a bit rusty with my JS!