[inference] fold openai support into provider param
#1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
commented
Feb 25, 2025
julien-c
commented
Feb 25, 2025
julien-c
commented
Feb 25, 2025
| @@ -757,7 +757,7 @@ describe.concurrent("HfInference", () => { | |||
| const hf = new HfInference(OPENAI_KEY); | |||
| const stream = hf.chatCompletionStream({ | |||
| provider: "openai", | |||
| model: "openai/gpt-3.5-turbo", | |||
There was a problem hiding this comment.
i'm wondering if we should still namespace model names and strip it in the implem? (just to keep consistency with HF repos..) 🤷
There was a problem hiding this comment.
I find it a bit redundant but ok to switch if you prefer
There was a problem hiding this comment.
(what if they OS it at some point in the future? etc)
|
I addressed the comment but won't continue until we know which direction we want to take. Just let me know and I'll check the tests |
Wauplin
requested review from
hanouticelina,
SBrandeis and
coyotte508
as code owners
SBrandeis
approved these changes
Feb 28, 2025
Wauplin
approved these changes
Feb 28, 2025
SBrandeis
changed the title
provider paramprovider param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ie. no need to override a
endpointanymoreThis only works in "client-side" mode ie when passing a provider key
WDYT?