Adding Merlin for accurate download count #1232
Conversation
ashwinkumargb
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
There was a problem hiding this comment.
Thanks for your PR @ashwinkumargb , this is exactly what's required! I left 2 comments below that I'll merge. For this PR to work, your repo will have to be tagged as merlin instead of Merlin. Can you update the library_name accordingly in the modelcard metadata (here https://huggingface.co/stanfordmimi/Merlin/blob/main/README.md?code=true#L5)
Once that's done, we should be good to merge!
| repoName: "merlin", | ||
| repoUrl: "https://github.com/StanfordMIMI/Merlin", | ||
| filter: false, | ||
| countDownloads: `path_filename:"i3_resnet_clinical_longformer_best_clip_04-02-2024_23-21-36_epoch_99.pt"`, |
There was a problem hiding this comment.
| countDownloads: `path_filename:"i3_resnet_clinical_longformer_best_clip_04-02-2024_23-21-36_epoch_99.pt"`, | |
| countDownloads: `path_extension:"pt"`, |
I fear that putting the filename will be too specific. Better to count downloads on .pt files instead. This way if you update the model in the repo or create a new repo with another trained Merlin model, then we won't have to update the countDownloads again.
|
Perfect, thank you so much for taking action on this so quickly! Yes, I have updated the model card to reflect "merlin". Please let me know if you need any other information! Do I need to modify config.json at all? Or will everything be handled in the backend? |
|
@ashwinkumargb thanks for updating the model card! From there nothing to do on your side. The new download count will be in effect within 4-5 days. |
I don't think we are getting an accurate download count for our hugging face repo: https://huggingface.co/stanfordmimi/Merlin, since the downloads page counts the queries to the config.json file and in our case the config.json file is empty. I was looking through the hugging face documentation and it seems like I had to add the file to the hugging face repo to allow it to have an accurate download count? Please let me know if I'm mistaken.