featureExtraction should use FeatureExtractionInput [v2] #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
requested review from
julien-c,
hanouticelina,
SBrandeis and
coyotte508
as code owners
coyotte508
approved these changes
Feb 27, 2025
|
ping on this as I'd like to move ahead with the changes in moon 🙏 |
SBrandeis
approved these changes
Feb 28, 2025
packages/inference/src/types.ts
Outdated
| @@ -87,6 +87,7 @@ export type RequestArgs = BaseArgs & | |||
| | { text: string } | |||
| | { audio_url: string } | |||
| | ChatCompletionInput | |||
| | FeatureExtractionInput | |||
There was a problem hiding this comment.
Not needed AFAIK (already covered by { inputs: unknown } at L85)
There was a problem hiding this comment.
handled in c57de75
mishig25
force-pushed
the
update_feature_extraction
branch
from
a3abfa8 to
c57de75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1235 (comment), recreating #1235 because: