-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inference snippets logic to inference package #1247
Move inference snippets logic to inference package #1247
Conversation
EDIT:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, though I still think we should merge those two packages...
This is a breaking change for @huggingface.js/tasks. Will require to make a major release?
I highly doubt anyone outside of HF was relying on the snippets being inside of tasks
For that matter, I doubt anyone outside of HF is importing tasks
(it's not really a library or natural building block imo)
I'll merge as-is for now and I'll consider merging everything together if I ever need to move parts again |
Original slack message from @Wauplin (private link):
=> after some discussions we went for "let's move the
snippets
code toinference
" which this PR does. @julien-c @coyotte508In practice I had to move only parts of the
./snippets
folder:@tasks
since it is used to generate some local app snippets@inference
=> i.e. only the logic to generate the snippets, not the helpers