-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the inline_inbuilt_nn_modules option #1617
Conversation
e62c993
to
4c1b7f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding notes for my understanding
without this change:
torch._dynamo.config.inline_inbuilt_nn_modules = True
https://github.com/pytorch/pytorch/blob/main/torch/_dynamo/config.py#L412C33-L412C42
with this change we give an option to set it to True or False. We set it to false in case of albert
@chaojun-zhang could you please resolve conflict. We'll try to merge it in for 1.20 |
4c1b7f8
to
a4c4f20
Compare
…ing to performance degradation in certain models(e.g. ALBERT_XXL). A configuration option has been introduced to turn off this behavior
a4c4f20
to
329cbdd
Compare
Updated |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@chaojun-zhang One more merge conflict to solve since I just merged #1619 |
Libin pushed a commit to resolve conflicts |
The code quality check failed, please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Disabling the inline_inbuilt_nn_modules switch will restore ALBERT-XXL's performance to PyTorch 2.4 levels
What does this PR do?
Fixes # (issue)
Before submitting