Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safe_globals to resume training on PyTorch 2.6 #1752

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yafshar
Copy link
Contributor

@yafshar yafshar commented Feb 6, 2025

What does this PR do?

Suggested in huggingface/transformers@1339a14, this is necessary for PyTorch version 2.6.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@yafshar yafshar marked this pull request as ready for review February 6, 2025 17:25
@yafshar yafshar requested a review from regisss as a code owner February 6, 2025 17:25
@yafshar
Copy link
Contributor Author

yafshar commented Feb 6, 2025

@libinta I recommend including this PR in the 1.20 release. It's already present in the future branch but hasn't been integrated into 1.20 yet.

@emascarenhas
Copy link
Contributor

@yafshar , why haven't seen this issue so far. We have been using pytorch 2.6.0.

@yafshar
Copy link
Contributor Author

yafshar commented Feb 6, 2025

@yafshar , why haven't seen this issue so far. We have been using pytorch 2.6.0.

I am not sure. What kind of examples or tests we tried with 2.6. Maybe just luck that the issue did not happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants