Skip to content

Commit

Permalink
debug dind
Browse files Browse the repository at this point in the history
  • Loading branch information
baptistecolle committed Jan 6, 2025
1 parent 068c6eb commit 38d2903
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 46 deletions.
84 changes: 42 additions & 42 deletions .github/workflows/debug-dind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,59 +26,59 @@ jobs:
# but it's not in a single step inside a python script so it can be run locally
# this scripts work on the local machine, not in the github actions environment
# i left commented out for now, as "Create test server Dockerfile", "Create minimal test server", "Build and run test container" maybe be easier to debug in a ci environment
# - name: Run test
# run: |
# python debug-dind-locally/test.py

- name: Create test server Dockerfile
- name: Run test
run: |
cat << EOF > Dockerfile
FROM us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:r2.4.0_3.10_tpuvm
python debug-dind-locally/test.py
# - name: Create test server Dockerfile
# run: |
# cat << EOF > Dockerfile
# FROM us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:r2.4.0_3.10_tpuvm

WORKDIR /app
RUN pip install fastapi uvicorn
# WORKDIR /app
# RUN pip install fastapi uvicorn

COPY server.py .
# COPY server.py .

EXPOSE 80
CMD ["uvicorn", "server:app", "--host", "0.0.0.0", "--port", "80"]
EOF
# EXPOSE 8080
# CMD ["uvicorn", "server:app", "--host", "0.0.0.0", "--port", "8080"]
# EOF

- name: Create minimal test server
run: |
cat << EOF > server.py
from fastapi import FastAPI
from pydantic import BaseModel
# - name: Create minimal test server
# run: |
# cat << EOF > server.py
# from fastapi import FastAPI
# from pydantic import BaseModel

app = FastAPI()
# app = FastAPI()

class GenerateRequest(BaseModel):
inputs: str
# class GenerateRequest(BaseModel):
# inputs: str

@app.post("/generate")
async def generate(request: GenerateRequest):
return {
"generated_text": "Hello World!",
"request_received": request.dict()
}
EOF
# @app.post("/generate")
# async def generate(request: GenerateRequest):
# return {
# "generated_text": "Hello World!",
# "request_received": request.dict()
# }
# EOF

- name: Build and run test container
run: |
docker build -t test-tgi-server .
docker run -d -p 80:80 --name test-server test-tgi-server
# - name: Build and run test container
# run: |
# docker build -t test-tgi-server .
# docker run -d -p 8080:8080 --name test-server test-tgi-server

sleep 5
# sleep 5

docker logs -f test-server &
# docker logs -f test-server &

sleep 10
# sleep 10

# Test the endpoint
curl --max-time 30 localhost:80/generate \
-X POST \
-d '{"inputs":"test message"}' \
-H 'Content-Type: application/json'
# # Test the endpoint
# curl --max-time 30 localhost:8080/generate \
# -X POST \
# -d '{"inputs":"test message"}' \
# -H 'Content-Type: application/json'

# Clean up
docker stop test-server
# # Clean up
# docker stop test-server
8 changes: 4 additions & 4 deletions debug-dind-locally/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ def create_dockerfile():
COPY server.py .
EXPOSE 80
CMD ["uvicorn", "server:app", "--host", "0.0.0.0", "--port", "80"]
EXPOSE 8080
CMD ["uvicorn", "server:app", "--host", "0.0.0.0", "--port", "8080"]
"""
with open("Dockerfile", "w") as f:
f.write(dockerfile_content)
Expand Down Expand Up @@ -50,7 +50,7 @@ def run_test():
print("Starting container...")
subprocess.run([
"docker", "run", "-d",
"-p", "0.0.0.0:80:80", # Explicitly bind to 0.0.0.0
"-p", "0.0.0.0:8080:8080", # Explicitly bind to 0.0.0.0
"--name", "test-server",
"--network", "host", # Use host networking
"test-tgi-server"
Expand All @@ -67,7 +67,7 @@ def run_test():
# Test endpoint using 0.0.0.0
print("\nTesting endpoint...")
curl_command = [
"curl", "--max-time", "30", "http://0.0.0.0:80/generate",
"curl", "--max-time", "30", "http://0.0.0.0:8080/generate",
"-X", "POST",
"-d", '{"inputs":"test message"}',
"-H", "Content-Type: application/json"
Expand Down

0 comments on commit 38d2903

Please sign in to comment.