Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sdxl refiner export #2133

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

eaidova
Copy link
Contributor

@eaidova eaidova commented Dec 20, 2024

What does this PR do?

after some refactoring export part, sdxl-refiner model become broken for exporting.
https://huggingface.co/stabilityai/stable-diffusion-xl-refiner-1.0
This model does not have text_encoder and only text_encoder_2, now export failed with AtributeError: 'NoneType' object has no attribute 'config'

see for reference https://github.com/huggingface/optimum-intel/actions/runs/12426942003/job/34696091118?pr=1085

@eaidova
Copy link
Contributor Author

eaidova commented Dec 20, 2024

@echarlaix @IlyasMoutawwakil could you please take a look?

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix @eaidova !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix
Copy link
Collaborator

It should have been caught by the CI, we need to add a test for this (looks like optimum-intel is using https://huggingface.co/echarlaix/tiny-random-stable-diffusion-xl-refiner which is not the case of optimum). @IlyasMoutawwakil let me know if you have some time for this otherwise I'll take care of it

@IlyasMoutawwakil
Copy link
Member

Yes the refiner architecture totally went over my head, thank for the fix @eaidova. Feel free to add a test in this PR or I'll add it in another one.

@IlyasMoutawwakil
Copy link
Member

Merging for the transformers 4.47 support

@IlyasMoutawwakil IlyasMoutawwakil merged commit 9840121 into huggingface:main Dec 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants