CD backports #1318
Merged
CD backports #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
`cargo check` doesnt work on my local configuration from `tokenizers/bindings/node/native` i don't think it will be a problem but i have difficulty telling
|
for |
|
Node is 12 and starting failing some time ago. I need to finish my node rewrite (which is done but I was fighting the distribution mecanism and couldn't make it work). In the meantime we're effectively dropping node, it can't slow the rest down. |
|
should |
|
Not really why ? Just what you're doing here is fine, minimal changes in the same way. |
|
all tests besides the node pass! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow
three commits that each implement
huggingface/safetensors#312
huggingface/safetensors#315
huggingface/safetensors#317
@Narsil do you think they should be separate PRs?
also how should I properly test them locally?
i'd hate to stress the PR build test infrastructure every time