drop deprecated params in tests

huggingface · Feb 7, 2025 · b968003 · b968003
1 parent cf10d1a
commit b968003
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/tests/test_sft_trainer.py b/tests/test_sft_trainer.py
@@ -327,7 +327,6 @@ def test_sft_trainer_uncorrect_data(self):
                 save_steps=1,
                 per_device_train_batch_size=2,
                 max_seq_length=32,  # make sure there is at least 1 packed sequence
-                num_of_sequences=32,
                 packing=True,
                 report_to="none",
             )
@@ -463,7 +462,6 @@ def test_sft_trainer_with_model_num_train_epochs(self):
                 num_train_epochs=2,
                 per_device_train_batch_size=2,
                 max_seq_length=16,
-                num_of_sequences=16,
                 packing=True,
                 report_to="none",
             )
@@ -537,7 +535,6 @@ def test_sft_trainer_with_model(self):
                 save_steps=1,
                 per_device_train_batch_size=2,
                 max_seq_length=16,
-                num_of_sequences=16,
                 packing=True,
                 report_to="none",
             )
@@ -562,7 +559,6 @@ def test_sft_trainer_with_model(self):
                 save_steps=1,
                 per_device_train_batch_size=2,
                 max_seq_length=16,
-                num_of_sequences=16,
                 packing=True,
                 report_to="none",
             )

diff --git a/tests/test_trainers_args.py b/tests/test_trainers_args.py
@@ -375,8 +375,6 @@ def test_sft(self):
                 model_init_kwargs={"trust_remote_code": True},
                 dataset_kwargs={"append_concat_token": True, "skip_prepare_dataset": True},
                 eval_packing=True,
-                num_of_sequences=32,
-                chars_per_token=4.2,
             )
             trainer = SFTTrainer(model_id, args=training_args, train_dataset=dataset)
             self.assertEqual(trainer.args.dataset_text_field, "dummy_text_field")
@@ -389,8 +387,6 @@ def test_sft(self):
             self.assertIn("append_concat_token", trainer.args.dataset_kwargs)
             self.assertEqual(trainer.args.dataset_kwargs["append_concat_token"], True)
             self.assertEqual(trainer.args.eval_packing, True)
-            self.assertEqual(trainer.args.num_of_sequences, 32)
-            self.assertEqual(trainer.args.chars_per_token, 4.2)
 
     @parameterized.expand([(False,), (True,)])
     def test_xpo(self, alpha_list):