Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix args type #1214

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix args type #1214

merged 2 commits into from
Jan 10, 2024

Conversation

zspo
Copy link
Contributor

@zspo zspo commented Jan 10, 2024

  1. adjust the parameter description.
  2. Correct the parameter type in the comment.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

younesbelkada
younesbelkada approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@younesbelkada younesbelkada merged commit 9f8d0e4 into huggingface:main Jan 10, 2024
9 checks passed
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@zspo
Fix args type (huggingface#1214)
81f045e 
* fix args type

* add args desc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zspo @HuggingFaceDocBuilderDev @younesbelkada