Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Optimize GRPO VRAM Usage by Computing Prompt Tokens Just Once #2669
base: main
Are you sure you want to change the base?
🔧 Optimize GRPO VRAM Usage by Computing Prompt Tokens Just Once #2669
Changes from 15 commits
851e04a
427b512
e3a3056
4cc06b8
fede783
ebcc49d
b5286a0
e003c6a
0d298b5
87421be
b31c1a9
69dbf38
a99b6ee
31e02be
a6c07a5
ae806f6
b067cf3
2e4fd45
1d4fe3c
78e9d9f
98773d9
7a88ed7
b903ebb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the full context, but if this shares memory per repeat (as an expand would) then perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so!