Small tweaks

hughjonesd · Jun 11, 2024 · 4902715 · 4902715
1 parent bcd10a9
commit 4902715
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/R/breaks-by-group-size.R b/R/breaks-by-group-size.R
@@ -32,7 +32,7 @@ brk_quantiles <- function (probs, ..., weights = NULL, recalc_probs = FALSE) {
 
     if (anyNA(qs)) return(empty_breaks()) # data was all NA
 
-    if (any(duplicated(qs))) {
+    if (anyDuplicated(qs) > 0L) {
       if (! recalc_probs) {
         warning("`x` has duplicate quantiles: break labels may be misleading")
       }

diff --git a/R/breaks.R b/R/breaks.R
@@ -31,8 +31,13 @@ brk_spikes <- function (breaks, n = NULL, prop = NULL) {
   assert_that(
     is.number(n) || is.number(prop),
     is.null(n) || is.null(prop),
-    msg = "exactly one of `n` and `prop` must be specified as a scalar numeric"
+    msg = "exactly one of `n` and `prop` must be a scalar numeric"
   )
+  assert_that(
+    # it's ok for one of these to be null
+    n >= 0 || prop >= 0
+  )
+
   if (! is.function(breaks)) breaks <- brk_default(breaks)
 
   function (x, extend, left, close_end) {

diff --git a/R/chop-isolates.R b/R/chop-isolates.R
@@ -101,7 +101,11 @@ dissect <- function (x,
   assert_that(
     is.number(n) || is.number(prop),
     is.null(n) || is.null(prop),
-    msg = "exactly one of `n` and `prop` must be specified as a scalar numeric"
+    msg = "exactly one of `n` and `prop` must be a scalar numeric"
+  )
+  assert_that(
+    # it's ok for one of these to be null
+    n >= 0 || prop >= 0
   )
 
   chopped <- chop(x, breaks, ...)