Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statcounter to statistics #1003

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

davidgs
Copy link
Contributor

@davidgs davidgs commented Oct 18, 2024

Issue

No issue created

Description

statcounter is a popular web stats site. Integrating it into toha was (previously) a pain, so this PR makes it super simple.

It follows the same configuration rules as the other web analytics options.

Test Evidence

statcounter-2
statcounter-1

The configuration parameters are picked up and put into the stat counter code in the header, as expected.

Add a `relcanonical: <URL>` item to the frontmatter and this will then make sure that the `<link rel="canonical" >` value is set properly.
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit ec98e49
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/671652095e88190007f43b1e
😎 Deploy Preview https://deploy-preview-1003--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hossainemruz
Copy link
Member

Thank you @davidgs! Look like the PR contains changes from you other PR. Can you please fix it?

Also, can you please guides here: https://github.com/hugo-toha/guides/blob/main/content/posts/analytics/index.md

@davidgs
Copy link
Contributor Author

davidgs commented Oct 18, 2024

Should be all updated. Added a PR to the guide, too

@hossainemruz
Copy link
Member

Can you please resolve the conflict?

@davidgs
Copy link
Contributor Author

davidgs commented Oct 18, 2024

resolved.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davidgs! Looks good now.

@hossainemruz hossainemruz changed the title add statcounter to statistics Add statcounter to statistics Oct 21, 2024
@hossainemruz hossainemruz added the hacktoberfest Mark an issue so that contributor participating hacktoberfest can work on it label Oct 21, 2024
@hossainemruz hossainemruz merged commit aa9b49b into hugo-toha:main Oct 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature hacktoberfest Mark an issue so that contributor participating hacktoberfest can work on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants