Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address most of Ben Kaduk's comments #166

Merged
merged 7 commits into from
Mar 21, 2022
Merged

Address most of Ben Kaduk's comments #166

merged 7 commits into from
Mar 21, 2022

Conversation

huitema
Copy link
Owner

@huitema huitema commented Mar 19, 2022

After that, there are only very few points left to address in Ben's comments (issue #158).

@huitema
Copy link
Owner Author

huitema commented Mar 19, 2022

@kaduk you may want to take a look at these changes, and also at the discussion in issue #156. The changes are in complement to Pr #158 that clarified that 0-RTT support is optional, and other PRs that addressed most of the IESG review comments.

Copy link
Contributor

@kaduk kaduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.
(I guess whether or not trailing whitespace is to be avoided is a matter of local policy.)

@huitema
Copy link
Owner Author

huitema commented Mar 21, 2022

@saradickinson please check my latest changes, and see whether that resolves your concerns.

@saradickinson
Copy link
Collaborator

@huitema yes - thank you!

@huitema huitema merged commit 6ec72f0 into master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants