Remove the remote HTTP connection to fetch the filesize

[johnbillion]

The performance of this plugin on my local Altis site was at a crawl. Each request to the attachments query Ajax endpoint was taking 20-30 seconds.

I narrowed down the problem to this call to get_headers(). It's called for each file in the result and performs a server side HTTP request to the URL in order to fetch its size. I can see that the file size is not exposed in the WordPress REST API, which I guess is the reason this code exists.

Removing this call brings the performance back to acceptable levels.

Removing this means the File size: section in the media manager contains no value, but this is a fair tradeoff to bring the performance back.

Regarding exposing the file size, we could:

• Open a WordPress core ticket to get the file size added to the REST API response, or
• Add an extra field to the REST API response via this plugin which would solve the problem for a Multisite network

In the meantime I propose simply removing this.

[onyekaa]

Fetching the size this way was supposed to be more performant but it's possible it could have been tested more aggressively. I'm surprised it took so long for you locally.

But I actually like your second suggestion. I think that would be quicker short-term solution.

[johnbillion]

Cheers Onyeka, I opened #7 for that.

[tfrommen]

Like Onyeka, I'm surprised that your local performance was that miserable. For me, it's also rather slow, bu "only" like about 5 seconds maybe.

Trying to add the filesize to the REST API response is something we can try, sure.

Let's remove the current request/info though. 👍

[johnbillion]

I'm using Altis local-server FWIW.