Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for plugin to use Amazon SDK directly. Clarify installation instructions. #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SteveRyan-ASU
Copy link

Putting this together from various comments and PRs for the project. This PR will.

  • Allow for the use of the plugin via direct git clone and composer install mechanisms.
  • Strongly suggest that the best way to use this plugin is to install it at the root of your project to prevent duplicate copies of the Amazon SDK from entering the codebase.

The solution to allow for both mechanisms to be used comes from this comment in the open PR #44.

The language included in the README file is borrowed from the commentary for issue #43.

Uses the proposed solution from PR#44 to allow for composer installations at the project root and within the plugin.
Borrows language from issue humanmade#43 to explain best practices for installation.
@henrywright
Copy link

@SteveRyan-ASU I just revisited this issue and came across your PR. It is a good improvement on my PR #44.

All looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants