feat!: establish baseline Node.js version support #184
Conversation
|
@nzakas Given this package is not doing anything especially fancy, would you consider dropping macOS from the build matrix? I'm not sure it's buying us much. |
|
No objections from me. |
boneskull
force-pushed
the
boneskull/expand-build-matrix
branch
from
c04dd0e to
1052075
Compare
|
@nzakas friendly ping for approval |
|
Gah sorry, just been buried lately. Thanks for the followup ping. |
| @@ -70,5 +70,8 @@ | |||
| "rollup": "4.23.0", | |||
| "typescript": "5.6.3", | |||
| "yorkie": "2.0.0" | |||
| }, | |||
| "engines": { | |||
| "node": "^16.20.0 || ^18.0.0 || ^20.0.0 || ^22.0.0" | |||
There was a problem hiding this comment.
I generally consider changing explicitly supported node versions as a breaking change. I don't mind doing it, but I do think we should bump major version for clarity. WDYT?
There was a problem hiding this comment.
Yes, that's fine. You do the releases/bumps manually, right?
There was a problem hiding this comment.
It's handled via release-please, so if we update the title of this PR to be "feat!: Set Node.js support" (or some such thing with "feat!" at the front), when this is merged, release-please creates a major version bump.
There was a problem hiding this comment.
great, right. I probably should have checked 😄
BREAKING CHANGE: Adds `engines.node` field in `package.json` with value of `^16.20.0 || ^18.0.0 || ^20.0.0 || ^22.0.0`. Versions which do not satisfy this range are unsupported. - Adds Node.js v22 to build matrix
boneskull
force-pushed
the
boneskull/expand-build-matrix
branch
from
1052075 to
41b3c07
Compare
boneskull
changed the title
|
@nzakas OK, this is ready for final approval. |
I wonder if adding the
enginesfield is going to break somebody. I guess I'd only really care if their package manager's default behavior is like enablingengineStrict? Is that a thing?