Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop recording with esc key #29

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

mactkg
Copy link
Contributor

@mactkg mactkg commented Apr 22, 2019

Implemented #15.

@neauoire
Copy link
Member

Perfect thanks :)

@neauoire neauoire merged commit 526d678 into hundredrabbits:master Apr 22, 2019
@mactkg mactkg deleted the stop-record-by-esc branch April 22, 2019 04:33
@mactkg
Copy link
Contributor Author

mactkg commented Apr 22, 2019

@neauoire Oh thank you for your fast response! 🏎

but I want to find a more suitable place of this code.
https://github.com/mactkg/Pilot/blob/ba0a8193cff1b8f3ae8aabc97cc2ed53c4ce2c35/desktop/sources/index.html#L54-L61

My first idea is write the code into commander.js because orca's code handle onkeydown or onkeyup in commander.js. However, Pilot's comander.js has different role a bit, and it's weird to write there.
If you have any good idea, please refactor the code 🙏

@neauoire
Copy link
Member

You could also replace with:

controller.add("default","File","Stop Recording",() => { pilot.recorder.stop() },"Escape")

@neauoire
Copy link
Member

Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants