bash best practices, loop change, parameterization of many things #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenewsted
commented
Jan 4, 2019
•
stevenewsted
commented
- Added a bunch of comments
- quoted a bunch of bash variables
- turned more things into parameters
- added a bunch of sanity/error checks
- added to the .gitignore file
- updated a bunch of readme info, with some changes, but a lot of style/editing cleanup
- etc
Switching shutdown to destroy in killall, for speed
…itespace in the 5-cluster.sh script
Adding some comments, cleaning a few things up, and fixing the bad wh…
Specifically, also removing the glusterfs disks that get created, and the leftover ssh known hosts info, so we don't have to manually run 'ssh-keygen -R blah'
Doing more cleanup when killing everything
updating some examples, and moving documentation to the readme
Updating a ton of stuff in the readme, and adding vim swp to gitignore
markup typo fixes
another markdown test
more cleanup
adding CPUMODEL as a env var for the build scripts
more bash cleanpup, and switching the for loop to a while to read in …
Refactored some vars
Set monitoring to install by default
Adding htpasswd identity file with admin user
Adding full list of playbooks, additional node group definitions
Explicitly set OpenShift package version
Removing explicit OpenShift package version
adding a subscription variables yaml
all steve-centric changes
Commented out cri-o variables
Refactored dnsmasq wildcard setup into Ansible role
Adding upgrade playbook reference for errata updates
Updating reference links to subcomponents
Adding glusterfs.yml
* Adding redeploy cert playbooks * Adding cert rotation playbooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.