Skip to content

Commit

Permalink
Bugfix: crash when reporting failure with dataset imported as file
Browse files Browse the repository at this point in the history
  • Loading branch information
huwjenkins committed Jul 28, 2022
1 parent e283a2f commit cae6438
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions process_datasets.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from dxtbx.serialize import load
from dxtbx.util import format_float_with_standard_uncertainty

__version__ = '0.3.4'
__version__ = '0.3.5'

class ProcessDataset:
def __init__(self, parameters):
Expand Down Expand Up @@ -45,7 +45,10 @@ def __call__(self, dataset):
if len(r.stderr_lines) > 0:
with open('dials.import.err', 'w') as f:
f.write('\n'.join(r.stderr_lines))
self.log.info(f'import of {dataset["template"]} failed!')
if dataset.get('template'):
self.log.info(f'import of {dataset["template"]} failed!')
else:
self.log.info(f'import of {dataset["file"]} failed!')
return

if self.parameters.get('generate_mask') and self.parameters['generate_mask'] != '':
Expand Down Expand Up @@ -117,7 +120,7 @@ def __call__(self, dataset):
with open('dials.index.err', 'w') as f:
f.write('\n'.join(r.stderr_lines))
if not os.path.isfile('indexed.expt'):
self.log.info(f'{dataset["template"]} failed to index in space group {self.parameters["spacegroup"]}')
self.log.info(f'{dataset_id} failed to index in space group {self.parameters["spacegroup"]}')
return

# refine (static)
Expand All @@ -127,7 +130,7 @@ def __call__(self, dataset):
with open('dials.refine_static.err', 'w') as f:
f.write('\n'.join(r.stderr_lines))
if not os.path.isfile('refined_static.expt'):
self.log.info(f'{dataset["template"]} failed in intitial refinement')
self.log.info(f'{dataset_id} failed in intitial refinement')
return

# refine (scan varying)
Expand All @@ -137,7 +140,7 @@ def __call__(self, dataset):
with open('dials.refine.err', 'w') as f:
f.write('\n'.join(r.stderr_lines))
if not os.path.isfile('refined.expt'):
self.log.info(f'{dataset["template"]} failed in scan varying refinement')
self.log.info(f'{dataset_id} failed in scan varying refinement')
return

# integrate
Expand All @@ -147,7 +150,7 @@ def __call__(self, dataset):
with open('dials.integrate.err', 'w') as f:
f.write('\n'.join(r.stderr_lines))
if not os.path.isfile('integrated.expt'):
self.log.info(f'{dataset["template"]} failed in integration')
self.log.info(f'{dataset_id} failed in integration')
return

# success
Expand Down

0 comments on commit cae6438

Please sign in to comment.