Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing and DNSMadeEasy API2.0 support #5

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

Testing and DNSMadeEasy API2.0 support #5

wants to merge 43 commits into from

Conversation

lopaka
Copy link

@lopaka lopaka commented Mar 18, 2014

Major changes:

  • Changed reserved attribute name :provider to :dns_provider
  • Created rspec/chefspec tests and fake cookbook
  • Created DNSMadeEasy API2.0 provider
  • Use 'xml' cookbook to install Fog dependencies, allowing wider OS support
  • Using Fog 1.20.0
  • Added comments to resources/default.rb

@slyness
Copy link
Member

slyness commented May 1, 2014

great @lopakadelp I will review this. Thank you.

slyness
slyness reviewed May 2, 2014
View reviewed changes
Berksfile
@@ -0,0 +1,7 @@
site :opscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's migrate this to librarian please.

Lopaka Delp added 20 commits May 2, 2014 15:25
@arangamani
Changed reserved attribute name :provider to :dns_provider
6e52661
@arangamani
Create dnsmadeeasy.rb provider using DNSMadeEasy v2.0 API calls
402c3d3
@arangamani
Changes made for test-kitchen.
f8b38fb
@arangamani
Added comments to dnsmadeeasy.rb provider.
4a557c9
@arangamani
Update fake recipe name.
9962dde
@arangamani
Use community 'xml' cookbook to install required dependencies for nok…
e64176a 
…ogiri, supporting other OSs.
@arangamani
Add DNSMadeEasy fake recipes.
f2f57ec
@arangamani
Update README with DNSMadeEasy example.
f812f9f
@arangamani
- Changed provider name so not to be confused with the Fog provider n…
c85a04f 
…ame.

- Replaced "Must be fog compatible" in README with links showing what to use.
- Added :dns_create_disable provider attribute to easily pass in node[:dns][:disable] in the provider.
@arangamani
Improved logging messages. Fixed syntax error.
358432a
@arangamani
Minor cosmetic changes to examples in README
445ff6a
@arangamani
Added comments to resources/default.rb explaining each used attribute.
523034b
@arangamani
Added more comments in resources/default.rb
dbfd6ae
@arangamani
Small cosmetic code changes.
1e69cb4
@arangamani
- Route53 adds a period to their records. Will take this into account…
2877594 
… when searching records.

- Default recipe does not pass in ttl.  Added the ttl attribute in default recipe.
@arangamani
Update README
dc4b086
@arangamani
Making the auth_headers helper method private.
8a00cce
@arangamani
Simple changes in simplified regex and removal of trailing whitespace
47a22f1
@arangamani
Adding trailing comma to follow local coding standards.
75276e7
@arangamani
Create method to generate API resource object.
a0eb909
Lopaka Delp and others added 23 commits May 2, 2014 15:28
@arangamani
Initial dir setup of spec tests
f0689c0
@arangamani
Additional dev on ChefSpec tests.
e5a1958
@arangamani
Continue dev of chefspec for dnsmadeeasy_api20 provider
677d87f
@arangamani
Finish dev of chefspec for dnsmadeeasy_api20 provider
21ae365
@arangamani
Added chefspec for removal of dns entry using dnsmadeeasy_api20 provider
1945520
@arangamani
Added chefspec test for default provider.
3468a22
@arangamani
Corrected CentOS version in spec_helper.rb
c848cef
@arangamani
Streamline and improve chefspec tests.
09521b7
@arangamani
Using rspec matchers to verify records
2d8e297
@arangamani
Cosmetic change to follow coding standards.
073ea7c
@arangamani
Following in-house rspec coding standards using "expect" instead of "…
26ec3d7 
…should".
@arangamani
Added Gemfile.
8d184c3
@arangamani
Improve validation of dnsmadeeasy_api20 credentials being passed.
f97a035
@arangamani
Replace raise with expect.
dffbfee
@arangamani
Update "it" descriptions.
f6f2f62
@arangamani
Using let to declare variables.
883b4d9
@arangamani
Using let to declare variables.
63eca9f
@arangamani
Bump version number.
9f11f8c
@arangamani
Changes based code review
64d8544 
- Changed to librarian-chef from Berkshelf.
- Renamed fake cookbook to dns-test.
- Fixed tests.
From code review, revert version to 0.1.3
151881c
Improve kitchen testing for DME API 2.0. If using old version of rest…
0fe0668 
…-client gem, set ssl_version to TLSv1.
Add Berksfile.lock to .gitignore. Add lazy back to entry_name in dns-…
01b2f58 
…test::dme.
@douglaswth
Merge pull request #5 from rightscale-cookbooks-contrib/disable_sslv3…
711a041 
…_communication_to_dme

Improve kitchen testing for DME API 2.0. If using old version of rest-cl...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lopaka @slyness @arangamani @douglaswth