Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New drawing functions introduced with Scalar-typed color argument #1008

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

go4orward
Copy link

For all the drawing functions (with color.RGBA color argument) in "imgproc.go",
new drawing functions below were added:

  • ArrowedLineWithScalar(img *Mat, pt1 image.Point, pt2 image.Point, s Scalar, thickness int)
  • CircleWithScalar(img *Mat, center image.Point, radius int, s Scalar, thickness int)
  • CircleWithScalarAndParams(img *Mat, center image.Point, radius int, s Scalar, thickness int, lineType LineType, shift int)
  • EllipseWithScalar(img *Mat, center, axes image.Point, angle, startAngle, endAngle float64, s Scalar, thickness int)
  • EllipseWithScalarAndParams(img *Mat, center, axes image.Point, angle, startAngle, endAngle float64, s Scalar, thickness int, lineType LineType, shift int)
  • LineWithScalar(img *Mat, pt1 image.Point, pt2 image.Point, s Scalar, thickness int)
  • RectangleWithScalar(img *Mat, r image.Rectangle, s Scalar, thickness int)
  • RectangleWithScalarAndParams(img *Mat, r image.Rectangle, s Scalar, thickness int, lineType LineType, shift int)
  • FillPolyWithScalar(img *Mat, pts PointsVector, s Scalar)
  • FillPolyWithScalarAndParams(img *Mat, pts PointsVector, s Scalar, lineType LineType, shift int, offset image.Point)
  • PolylinesWithScalar(img *Mat, pts PointsVector, isClosed bool, s Scalar, thickness int)

Nothing else changed.

@go4orward
Copy link
Author

In fact, this is the first time I ever made a pull request on Github project.
So, please let me know if there's any mistake on my side in the process.

@deadprogram
Copy link
Member

Thanks for starting work on this @go4orward

Could you please add "smoke tests" for the new functions? See https://github.com/hybridgroup/gocv/blob/release/CONTRIBUTING.md#how-to-add-a-function-from-opencv-to-gocv for more info.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants