Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor the overridden Craft mailer component #188

Open
wants to merge 1 commit into
base: develop-v4
Choose a base branch
from

Conversation

nstCactus
Copy link

Although niche, it is a valid use case to override the Craft mailer component (see https://craftcms.com/docs/3.x/config/#mailer-component). In such cases, the plugin doesn't honor the from property of the overridden mailer component and instead forces the use of the email settings from project config (set in the control panel).

This PR corrects this behavior by always using the from property of the mailer component:

  • if it hasn't been overridden, its default value is the one set in the CP
  • if it has been overridden, the overridden value is used

@rosskenney rosskenney self-requested a review February 7, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant