chore: fix firefox test runner

hybridsjs · Jan 8, 2024 · 311cef1 · 311cef1
1 parent 435befc
commit 311cef1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,12 +16,11 @@ jobs:
           node-version: 19
           cache: "npm"
       - uses: browser-actions/setup-chrome@latest
-      - uses: browser-actions/setup-firefox@latest
 
       - name: Install dependencies
         run: |
           npm install
-          npx playwright install-deps webkit
+          npm test:prepare
       - name: Run tests
         run: |
           npm run test

diff --git a/karma.conf.cjs b/karma.conf.cjs
@@ -1,6 +1,8 @@
 const playwright = require("playwright");
 
 process.env.WEBKIT_HEADLESS_BIN = playwright.webkit.executablePath();
+process.env.FIREFOX_BIN = playwright.firefox.executablePath();
+
 const IS_COVERAGE = process.env.NODE_ENV === "coverage";
 
 module.exports = (config) => {
@@ -34,7 +36,7 @@ module.exports = (config) => {
     },
     autoWatch: true,
     singleRun: true,
-    concurrency: process.env.GITHUB_ACTIONS ? 1 : Infinity,
+    concurrency: 1,
     port: 9876 + Number(IS_COVERAGE),
   });
 };
diff --git a/package.json b/package.json
@@ -41,6 +41,7 @@
     "dev:coverage": "rm -rf ./coverage && NODE_ENV=coverage npm run dev",
     "lint": "eslint ./src",
     "test": "npm run test:cli && npm run lint && npm run karma",
+    "test:prepare": "playwright install firefox webkit",
     "test:coverage": "rm -rf ./coverage && NODE_ENV=coverage npm run karma",
     "test:cli": "node ./cli/test.js",
     "release": "npm run test && standard-version -a"