fix(cache): Clear deps and context when get value from cache #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #229
Still updating properties in a chain of the observer can lead to out-of-date UI, as the
render
method is added to the emitter queue when the first of its dependencies has changed. Added test to this PR shows that case - render is called after theprop1
observer, so theprop1
andprop2
are updated, but before theprop3
(it is added to the queue when render is there already).However, the PR fixes the issue where the state after that action is broken, and
render
has no deps anymore (before callinghost.prop3 = ...
cleared out deps/contexts of a whole tree, so render has no deps then, but it also will not be called, as it was called already).