Refactor and normalize bootstrapping #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
============================================
+ Coverage 95.04% 97.14% +2.09%
Complexity 29 29
============================================
Files 6 6
Lines 101 105 +4
============================================
+ Hits 96 102 +6
+ Misses 5 3 -2 ☔ View full report in Codecov by Sentry. |
This will force regeneration when updating the binary
These extensionless files were missed before
caendesilva
force-pushed
the
clean-up-bootstrapping
branch
2 times, most recently
from
88dce03 to
6ba1ce7
Compare
caendesilva
force-pushed
the
clean-up-bootstrapping
branch
from
6ba1ce7 to
0262bd5
Compare
caendesilva
added
the
halt-matrix-tests
This reverts commit cf998f9.
This is now no longer needed since the bootstrappers are normalized.
caendesilva
force-pushed
the
clean-up-bootstrapping
branch
2 times, most recently
from
aac18ef to
8145e41
Compare
caendesilva
force-pushed
the
clean-up-bootstrapping
branch
from
8145e41 to
c850fea
Compare
caendesilva
changed the title
caendesilva
removed
the
halt-matrix-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors and normalizes the standalone binary bootstrapping process to be more modular and clean.