-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make instrumentation pluggable #37
Conversation
1508417
to
303b423
Compare
4a58e67
to
cc8e4c1
Compare
I appreciate the work, will look at this soon, sorry for the delay. |
62efe77
to
ddb5b19
Compare
Thanks! To be clear: I'm not asking for a code review – just whether it does everything you need. :) |
Looks good to me - tomorrow I'll try plugging it into datadog. One small semantic question -
It looks like if a hook raises, that will raise out of |
It is, because it's impossible to revert that user-side. You can always add a |
LMK when you need a third-party extensions wiki page. ;) |
Ref #27
Does this look sufficient for you @jdunck (and everybody else)?
Rendered docs here: https://py-stamina--37.org.readthedocs.build/en/37/instrumentation.html