Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasi): add wasi crate support #720

Closed
wants to merge 1 commit into from

Conversation

rvolosatovs
Copy link

This adds some very basic and common conversions to and from wasi:http types using generated bindings from wasi crate.

This opt-in feature is gated behind wasi feature flag.

I did not write a test case for the header conversion to avoid pulling in a runtime at this point.

Refs:

Signed-off-by: Roman Volosatovs <[email protected]>
@seanmonstar
Copy link
Member

I don't think we'd add a public dependency here. Adding any public dependency is a risky move, and wasi isn't stable yet, so more so. Once a dependency is publicly exposed, it's semver becomes ours. We don't want to have to release a v2 to upgrade a dependency.

I clicked around the links you mentioned, and it seems like support already exists in another crate.

@rvolosatovs
Copy link
Author

I don't think we'd add a public dependency here. Adding any public dependency is a risky move, and wasi isn't stable yet, so more so. Once a dependency is publicly exposed, it's semver becomes ours. We don't want to have to release a v2 to upgrade a dependency.

I clicked around the links you mentioned, and it seems like support already exists in another crate.

fair enough

@rvolosatovs rvolosatovs deleted the feat/wasi branch October 28, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants