Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of snapcraft temporarily #1232

Closed

Conversation

sapiderman
Copy link
Contributor

@sapiderman sapiderman commented Jan 16, 2024

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Having issues with the oclif pack tarball and workspaces
  2. While we fix it/find alternative, disable mention of snapcraft for now.

How did you implement / how did you fix it

  1. Only removed reference to snapcraft in the quick-start.md

Testing

  1. standard npm run test should run without errors.
  2. pipelines should run without errors.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dc57cb) 63.71% compared to head (feba3fd) 63.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1232   +/-   ##
=======================================
  Coverage   63.71%   63.71%           
=======================================
  Files         111      111           
  Lines        3296     3296           
  Branches      566      566           
=======================================
  Hits         2100     2100           
  Misses       1006     1006           
  Partials      190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sapiderman sapiderman marked this pull request as ready for review January 16, 2024 04:24
@sapiderman sapiderman marked this pull request as draft January 19, 2024 03:27
@sapiderman
Copy link
Contributor Author

Holy Moly Balls of Fire! Was preparing screens for to create an issue in he oclif site and retrying (failing) to recreate the error. Suddenly works! WTH! Hence will update.

@sapiderman
Copy link
Contributor Author

snapcraft publish success

image

@sapiderman sapiderman closed this Feb 22, 2024
@sapiderman sapiderman deleted the doc/remove-snapcraft-fornow branch June 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants