Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native fetch): create --experimental-fetch as toggle feature #1240

Conversation

syamsudotdev
Copy link
Contributor

Monika Pull Request (PR)

This PR resolves #1237

What feature does this PR add

  1. Create --experimental-fetch as toggle feature flag to change HTTP client

How did you implement

  1. Added new flag --experimental-fetch
  2. Added new tests for startup message

How to test

  1. npm run test
  2. Compare startup message npm run start with npm run start -- --experimental-fetch

Screenshot

image

@syamsudotdev syamsudotdev self-assigned this Feb 23, 2024
@syamsudotdev syamsudotdev changed the title create --experimental-fetch as toggle feature feat(native fetch): create --experimental-fetch as toggle feature Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (d96b3e1) to head (8fd3274).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
+ Coverage   63.47%   63.49%   +0.02%     
==========================================
  Files         111      111              
  Lines        3302     3304       +2     
  Branches      568      569       +1     
==========================================
+ Hits         2096     2098       +2     
  Misses       1016     1016              
  Partials      190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syamsudotdev syamsudotdev marked this pull request as ready for review February 23, 2024 13:51
@syamsudotdev syamsudotdev changed the title feat(native fetch): create --experimental-fetch as toggle feature feat(native fetch): create --experimental-fetch as toggle feature Feb 23, 2024
@syamsudotdev syamsudotdev changed the title feat(native fetch): create --experimental-fetch as toggle feature feat(native fetch): create --experimental-fetch as toggle feature Feb 23, 2024
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@syamsudotdev syamsudotdev merged commit a907167 into hyperjumptech:main Feb 27, 2024
7 checks passed
@syamsudotdev syamsudotdev deleted the issue/1237-experimental-fetch-flag branch February 27, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create experimental flag to switch between Axios and native Node.js fetch for HTTP client
3 participants