Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Remove axios package #1310

Closed
wants to merge 9 commits into from
Closed

[Feat] Remove axios package #1310

wants to merge 9 commits into from

Conversation

irwansyahwii
Copy link

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Implements Remove Axios package and defaults to Node.js fetch #1248
  2. Replace Axios with node's fetch()

How did you implement / how did you fix it

  1. Create an adapter to prevent big changes on the client codes
  2. Remove all dependencies to Axios
  3. Leave the Jira plugin intacts

How to test

  1. npm test should all pass

@irwansyahwii irwansyahwii marked this pull request as draft July 10, 2024 13:20
@irwansyahwii irwansyahwii marked this pull request as ready for review July 10, 2024 13:20
@irwansyahwii irwansyahwii reopened this Jul 10, 2024
@irwansyahwii
Copy link
Author

@sapiderman

@irwansyahwii irwansyahwii mentioned this pull request Jul 11, 2024
Closed
@sapiderman
Copy link
Contributor

thanks! this looks better than my pr. Will review.

@dennypradipta
Copy link
Contributor

Please resolve conflicts

@irwansyahwii irwansyahwii deleted the remove-axios-package branch July 19, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haricnugraha haricnugraha Awaiting requested review from haricnugraha

@syamsudotdev syamsudotdev Awaiting requested review from syamsudotdev

@nicnocquee nicnocquee Awaiting requested review from nicnocquee

@raosan raosan Awaiting requested review from raosan

@ilmiawan ilmiawan Awaiting requested review from ilmiawan

@dennypradipta dennypradipta Awaiting requested review from dennypradipta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irwansyahwii @sapiderman @dennypradipta