fix(NonceManager): off-by-one error resyncing onchain nonce #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
force-pushed
the
dan/noncemanager-fix
branch
from
ac6b057 to
ca44d34
Compare
ameten
approved these changes
Jan 7, 2025
tkporter
reviewed
Jan 7, 2025
| let onchain_nonce = self | ||
| .get_transaction_count(self.address, block) | ||
| .await? | ||
| .saturating_sub(1.into()); |
There was a problem hiding this comment.
there's an edge case here if it's the first ever tx, where get_transaction_count returns 0. Think it's a concern or that it's fine for now?
There was a problem hiding this comment.
this branch would only be hit after tx_count_for_resync txs which is >0 so we're good, but it would be a concern if tx_count_for_resync was 0
There was a problem hiding this comment.
actually if none of the tx_count_for_resync land this would be a problem, but I think it's very unlikely we run into that
even if we store 0, because of next() we end up using 1 so we're good even if all initial tx_count_for_resync txs get stuck
|
closing as this was a false alarm, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_transaction_countRPC returns the latest nonce that landed onchain + 1. The intended behavior when resyncing internal nonce is to set it to that latest nonce (without the +1). This wasn't the case so far, which made it possible to still get stuck nonces.Will add a follow up test PR where the escalator randomly drops every Nth tx (and implicitly its nonce), to make sure nonce resyncing works.