-
Notifications
You must be signed in to change notification settings - Fork 343
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### Description - we were recovering `TestRecipient` from sdk artifacts which means the deployer won't have ownership. So, I added a optional `shouldRecover` boolean which I turned off for TestRecipient deployer (this is only for our artifacts, if they have their own testRecipient, it will still recover that if provided) - moved `TestRecipientDeployer` from cli to sdk and removed duplicated code from infra ### Drive-by changes None ### Related issues - fixes hyperlane-xyz/issues#895 ### Backward compatibility Yes ### Testing Manual (between anvil1 and optimismgoerli)
- Loading branch information
1 parent
d3d7ad7
commit 67a6d97
Showing
7 changed files
with
62 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@hyperlane-xyz/infra': patch | ||
'@hyperlane-xyz/cli': patch | ||
'@hyperlane-xyz/sdk': patch | ||
--- | ||
|
||
Added `shouldRecover` flag to deployContractFromFactory so that the `TestRecipientDeployer` can deploy new contracts if it's not the owner of the prior deployments (We were recovering the SDK artifacts which meant the deployer won't be able to set the ISM as they needed) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
typescript/infra/src/deployment/testcontracts/testrecipient.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters