Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup chain parsing #2464

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Dedup chain parsing #2464

merged 2 commits into from
Jul 3, 2023

Conversation

mattiekat
Copy link
Contributor

Description

Missed this by accident from #2249

Drive-by changes

None

Related issues

Backward compatibility

Are these changes backward compatible?

Yes

Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?

None

Testing

What kind of testing have these changes undergone?

Unit Tests

@mattiekat mattiekat changed the title Dedup Dedup chain parsing Jul 3, 2023
@mattiekat mattiekat enabled auto-merge (squash) July 3, 2023 19:47
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (420383e) 64.71% compared to head (e7c30b2) 64.71%.

❗ Current head e7c30b2 differs from pull request most recent head f27e948. Consider uploading reports for the commit f27e948 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2464   +/-   ##
=======================================
  Coverage   64.71%   64.71%           
=======================================
  Files          83       83           
  Lines        1312     1312           
  Branches      171      171           
=======================================
  Hits          849      849           
  Misses        456      456           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattiekat mattiekat merged commit 16a29ed into main Jul 3, 2023
20 checks passed
@mattiekat mattiekat deleted the mattie/dedup-chain-parsing branch July 3, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants