WIP FallbackRwLock #2893
Closed
WIP FallbackRwLock #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
reviewed
Nov 7, 2023
| self.0 | ||
| .try_write() | ||
| .map(FallbackRwLockWriteGuard::RwLock) | ||
| .or_else(|_| Ok(FallbackRwLockWriteGuard::Fallback(Box::new(fallback())))) |
There was a problem hiding this comment.
Since this fallback closure is unlikely to change once the FallbackRwLock is created, you could even set the fallback closure in the constructor (assuming it's not FnOnce)
You could also define your own FallbackRwLock trait that comes with a default implementation for try_write_or, and uses required implementations for fallback() and try_write(). This would then allow for having different off-the-shelf fallback clients. If you also add a client() fn to the trait, you could then have a default fallback() implementation of just cloning the returned client()
|
No longer relevant 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing