Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:remove agentStartBlock and use mailbox.deployedBlock() instead #3005

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

aroralanuk
Copy link
Contributor

Description

  • CLI was using a static start block numbers for core chains or getting the latest block number from a PI chain for agent config which is redundant and dangerous. Instead, I updated to using the mailbox.deployedBlock() which should precede all other indexable contract deployment and is hence safer.

Drive-by changes

  • filtering the agent configs in CLI is redundant since the HyperlaneDeploymentArtifactsSchema requires all the specified entries and if writeAgentConfig gets an artifacts which doesn't contain these, we should throw an error and not filter them.

Related issues

Backward compatibility

Yes

Testing

Manual b/w anvil1 and anvil2

Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: 325e11f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/infra Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup :)

typescript/infra/src/deployment/deploy.ts Show resolved Hide resolved
@aroralanuk aroralanuk merged commit 9f2c7ce into main Nov 30, 2023
10 of 16 checks passed
@aroralanuk aroralanuk deleted the kunal/rm-agent-start-blocks branch November 30, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants