Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX of send and status commands #3006

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Improve UX of send and status commands #3006

merged 10 commits into from
Dec 4, 2023

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Nov 30, 2023 •
edited
Loading

Description

  • Improve shared context utility with conditional typing and core artifact handling
  • Improve UX of send and status commands with prompts
  • Prompt for key if required and not provided

Drive-by Changes

Update the token readme for https://github.com/hyperlane-xyz/issues/issues/715

Backward compatibility

Yes

Testing

Manual

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 193e23c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jmrossy jmrossy marked this pull request as ready for review November 30, 2023 19:09
@jmrossy
Copy link
Contributor Author

jmrossy commented Nov 30, 2023

More updates for https://github.com/hyperlane-xyz/issues/issues/713

@jmrossy jmrossy mentioned this pull request Dec 1, 2023
Merged
@avious00
Copy link
Contributor

avious00 commented Dec 1, 2023

thanks for adding in the context / coreartifact section, LGTM

aroralanuk
aroralanuk reviewed Dec 4, 2023
View reviewed changes
typescript/cli/src/commands/send.ts Show resolved Hide resolved
typescript/cli/src/commands/send.ts Show resolved Hide resolved
typescript/cli/src/context.ts Show resolved Hide resolved
typescript/cli/src/context.ts Show resolved Hide resolved
typescript/cli/src/send/message.ts Show resolved Hide resolved
typescript/cli/src/send/transfer.ts Show resolved Hide resolved
@jmrossy jmrossy merged commit 9705079 into main Dec 4, 2023
9 of 16 checks passed
@jmrossy jmrossy deleted the rossy/improve-cli-context branch December 4, 2023 20:09
@jmrossy jmrossy mentioned this pull request Dec 4, 2023
Merged
jmrossy added a commit that referenced this pull request Dec 4, 2023
@jmrossy
Remove demand option for router arg of send transfer (#3018)
c65b598 
Fix for missing bit of #3006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aroralanuk aroralanuk aroralanuk approved these changes

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@Skunkchain Skunkchain Awaiting requested review from Skunkchain

@nambrot nambrot Awaiting requested review from nambrot

@avious00 avious00 Awaiting requested review from avious00

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmrossy @avious00 @aroralanuk