Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerZero Hook and ISM #3094

Closed
wants to merge 4 commits into from
Closed

LayerZero Hook and ISM #3094

wants to merge 4 commits into from

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Dec 21, 2023

Description

Drive-by changes

Related issues

Backward compatibility

Yes

Testing

Manual/Unit Tests

Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 8ee79a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@avious00
Copy link
Contributor

hey @ltyu just ran the checks for you - is this ready for review?

excited to see all of your contributions recently

@ltyu
Copy link
Contributor Author

ltyu commented Dec 23, 2023

hey @ltyu just ran the checks for you - is this ready for review?

excited to see all of your contributions recently

Nope, this is about 40% done. Probably be done by next week since I will be on holiday.

Comment on lines +82 to +104
function _quoteDispatch(
bytes calldata metadata,
bytes calldata message
) internal view virtual override returns (uint256) {
bytes calldata lZMetadata = metadata.getCustomMetadata();
(
uint16 dstChainId,
address userApplication,
,
bytes memory payload,
,
bytes memory adapterParam
) = parseLzMetadata(lZMetadata);

(uint256 nativeFee, ) = lZEndpoint.estimateFees(
dstChainId,
userApplication,
payload,
false,
adapterParam
);
return nativeFee;
}
@ltyu
Copy link
Contributor Author

ltyu commented Dec 25, 2023

Incorrectly merging from main. Closing this for #3102.

@ltyu ltyu closed this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants