feat(cli): enable HypFiatCollateral warp route deployments #3952
Conversation
AlexBHarley
requested review from
jmrossy,
yorhodes,
aroralanuk and
nbayindirli
as code owners
🦋 Changeset detectedLatest commit: 7cb2d10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3952 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 129 129
Lines 1659 1659
Branches 177 177
=======================================
Hits 1002 1002
Misses 630 630
Partials 27 27
|
typescript/cli/src/deploy/warp.ts
Outdated
| config.type === TokenType.collateral || | ||
| config.type == TokenType.collateralFiat |
There was a problem hiding this comment.
Looks like @ltyu added a list recently that would be helpful here: https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/3838/files#diff-a1429ad1c3e9d3fe43d28f08333e95f6c79176b6d36873e42e455e5e806826aaR16
There was a problem hiding this comment.
@jmrossy what's the timeline for CLI 2.0, or are people already trying it out?
Could do this branch on top of that if we prefer. Otherwise a TODO seems appropriate
There was a problem hiding this comment.
TODO is fine
will followup when we are merging CLI 2.0, hopefully in a couple days
|
closing this as a dupe to #4133 |
Description
Small fix to the CLI to enable HypFiatCollateral warp route deployments.
My understanding is that all the collateral Hyp tokens require the
collateralAddressOrDenomproperty in their warp route config.You can test this here, just ping me for some of the fake USDC tokens.
Drive-by changes
N/A
Related issues
Backward compatibility
Yes
Testing
CLI and warp UI