Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contracts): owner vault metadata compatibility #4566

Open
wants to merge 4 commits into
base: kunal/4626-nonce
Choose a base branch
from
Open

fix(contracts): owner vault metadata compatibility #4566

wants to merge 4 commits into from

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Sep 24, 2024 •
edited
Loading

Description

  • Added PRECISION and rateUpdateNonce to ensure compatibility of HypERC4626 (even though this is not a useful warp route bc exchangeRate will stay at 1e10)

Drive-by changes

None

Related issues

Backward compatibility

No

Testing

Unit test

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dd8c4bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aroralanuk aroralanuk changed the base branch from main to kunal/4626-nonce September 24, 2024 18:45
@aroralanuk aroralanuk marked this pull request as ready for review September 25, 2024 08:44
@aroralanuk aroralanuk changed the title fix(contracts): WIP owner vault metadata compatibility fix(contracts): owner vault metadata compatibility Sep 26, 2024
yorhodes
yorhodes reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contribution boosting ⏩

solidity/contracts/token/extensions/HypERC4626.sol Outdated Show resolved Hide resolved
solidity/contracts/token/extensions/HypERC4626OwnerCollateral.sol Outdated Show resolved Hide resolved
solidity/contracts/token/extensions/HypERC4626OwnerCollateral.sol
_depositIntoVault(_amount);
rateUpdateNonce++;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it not possible to use the message nonce for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to maintain consistency with the Hyp4626Collateral

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes left review comments

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aroralanuk @yorhodes