Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: from addresses for eth_estimateGas #4588

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geet-eth
Copy link

Description

addresses Issue #4585
adding/ed parameter from: Option<H256> to the mailbox trait, SerialSUbmitter takes a from address param, then updates serial submitter in relayer.rs to accept the from address. basically just set the from address for eth_estimateGas from chain configs.
very messy rn after making oopsie but will clean and send for review in the am
Steps:
todo

Drive-by changes

todo

Related issues

Backward compatibility

no

Testing

todo

Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: 9804f73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@geet-eth geet-eth changed the title chore wip: from addresses for eth_estimateGas Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant