Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add block tag support in reorgPeriod parameter #4629

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

apastushenka
Copy link

Description

Allows setting an arbitrary string in reorgPeriod, which is used as a block tag to get the finalized block. Currently, only the Ethereum connector supports this feature with the following tags:

  • finalized
  • safe
  • pending
  • latest
  • earliest

This is currently useful for EVM-compatible chains that don't have a fixed reorganization period, but instead rely on the block tag Finalized to indicate finality. For such chains, you should set reorgPeriod to finalized instead of a number of blocks.

Drive-by changes

Related issues

Backward compatibility

Yes

Testing

Copy link

changeset-bot bot commented Oct 5, 2024

⚠️ No Changeset found

Latest commit: 9a5640b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@apastushenka apastushenka changed the title Add block tag support in reorgPeriod parameter feat: Add block tag support in reorgPeriod parameter Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant